Add ZINBParams tests

R/AllClasses.R

@@ -559,7 +559,8 @@ setClass("PhenoParams",
 #'
 #' The majority of the parameters for this simulation are stored in a
 #' \code{\link[zinbwave]{ZinbModel}} object. Please refer to the documentation
-#' for this class for details about all the parameters.
+#' for this class and its constructor(\code{\link[zinbwave]{zinbModel}}) for
+#' details about all the parameters.
 #'
 #' The parameters not shown in brackets can be estimated from real data using
 #' \code{\link{zinbEstimate}}. For details of the ZINB-WaVE simulation

R/ZINBParams-methods.R

@@ -38,14 +38,19 @@ setValidity("ZINBParams", function(object) {
 setMethod("setParam", "ZINBParams", function(object, name, value) {
     checkmate::assertString(name)
 
-    if (name %in% names(getSlots("ZinbModel"))) {
-        model <- getParam(object, "model")
-        slot(model, name) <- value
-        object <- setParam(object, "model", model)
-    } else {
-        object <- callNextMethod()
+    if (name %in% c("nGenes", "nCells")) {
+        stop(name, " cannot be set directly, set model instead")
+    }
+
+    if (name == "model") {
+        object <- setParamUnchecked(object, "nGenes",
+                                    zinbwave::nFeatures(value))
+        object <- setParamUnchecked(object, "nCells",
+                                    zinbwave::nSamples(value))
     }
 
+    object <- cellNextMethod()
+
     return(object)
 })
 

tests/testthat/test-PhenoParams.R

 context("PhenoParams")
 
 test_that("constructor is valid", {
-    expect_true(validObject(newSCDDParams()))
+    expect_true(validObject(newPhenoParams()))
 })
 
 test_that("nGenes checks work", {

tests/testthat/test-ZINBParams.R

+context("ZINBParams")
+
+test_that("constructor is valid", {
+    expect_true(validObject(newZINBParams()))
+})
+
+test_that("nGenes checks work", {
+    params <- newZINBParams()
+    expect_error(setParam(params, "nGenes", 1),
+                 "nGenes cannot be set directly")
+    expect_error(setParam(params, "nCells", 1),
+                 "nGenes cannot be set directly")
+})